Skip to content

Remove example with poor performance #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rapids-bot merged 5 commits into from
Oct 15, 2025
Merged

Remove example with poor performance #1011

rapids-bot merged 5 commits into from
Oct 15, 2025

Conversation

@dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Oct 15, 2025 •
edited by coderabbitai bot
Loading

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Summary by CodeRabbit

  • Documentation

    • Removed the Redacting Sensitive Data section from the observability workflow docs.
    • Deleted the PII redaction example documentation.
    • Updated the Examples README to remove the PII redaction entry.

  • Chores

    • Removed the PII redaction example, including its configs and build metadata.
    • Cleaned project configuration to drop references to the removed example.
    • No changes to public APIs or runtime behavior.

@dagardner-nv dagardner-nv self-assigned this Oct 15, 2025
@dagardner-nv dagardner-nv requested review from a team as code owners October 15, 2025 18:58
@dagardner-nv dagardner-nv added doc Improvements or additions to documentation breaking Breaking change labels Oct 15, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 15, 2025 •
edited
Loading

Walkthrough

Removed the redact_pii observability example and related documentation. Deleted example package files, configuration, and entry points. Pruned references in examples index and root pyproject. Updated Weave observability docs by removing PII redaction content. No new features or public APIs added.

Changes

Cohort / File(s) Summary of changes
Docs — Weave PII redaction removal
docs/source/workflows/observe/observe-workflow-with-weave.md		 Removed the entire Redacting Sensitive Data section; retained remaining Weave tracing content.
Examples index update
examples/README.md		 Removed the Observability bullet referencing redact_pii.
Example: redact_pii removal
examples/observability/redact_pii/README.md, examples/observability/redact_pii/pyproject.toml, examples/observability/redact_pii/configs, examples/observability/redact_pii/src/nat_redact_pii/configs/weave_redact_pii_config.yml, examples/observability/redact_pii/src/nat_redact_pii/register.py		 Deleted the redact_pii example, including documentation, build metadata, configs, YAML config, and registered function/config class implementation.
Build config cleanup
pyproject.toml		 Removed nat_redact_pii from the examples list.

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

non-breaking

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title “Remove example with poor performance” is imperative, concise, under 72 characters, and accurately describes the removal of a performance-heavy example from the documentation and code.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 24a4bc5 and 0d5155b.

⛔ Files ignored due to path filters (2)
  • examples/observability/redact_pii/images/redact_weave_trace.png is excluded by !**/*.png
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (8)
  • docs/source/workflows/observe/observe-workflow-with-weave.md (0 hunks)
  • examples/README.md (0 hunks)
  • examples/observability/redact_pii/README.md (0 hunks)
  • examples/observability/redact_pii/configs (0 hunks)
  • examples/observability/redact_pii/pyproject.toml (0 hunks)
  • examples/observability/redact_pii/src/nat_redact_pii/configs/weave_redact_pii_config.yml (0 hunks)
  • examples/observability/redact_pii/src/nat_redact_pii/register.py (0 hunks)
  • pyproject.toml (0 hunks)
💤 Files with no reviewable changes (8)
  • examples/observability/redact_pii/src/nat_redact_pii/register.py
  • examples/observability/redact_pii/pyproject.toml
  • docs/source/workflows/observe/observe-workflow-with-weave.md
  • examples/README.md
  • pyproject.toml
  • examples/observability/redact_pii/README.md
  • examples/observability/redact_pii/configs
  • examples/observability/redact_pii/src/nat_redact_pii/configs/weave_redact_pii_config.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dagardner-nv dagardner-nv removed the request for review from a team October 15, 2025 18:58
@willkill07 willkill07 mentioned this pull request Oct 15, 2025
Closed
@coderabbitai coderabbitai bot added the non-breaking Non-breaking change label Oct 15, 2025
willkill07
willkill07 requested changes Oct 15, 2025
View reviewed changes
@willkill07 willkill07 removed the non-breaking Non-breaking change label Oct 15, 2025
@dagardner-nv
Restore removed documentation
305918a 
Signed-off-by: David Gardner <[email protected]>
@dagardner-nv
Copy link
Contributor Author

dagardner-nv commented Oct 15, 2025

/merge

@rapids-bot rapids-bot bot merged commit 6bb4c9c into NVIDIA:release/1.3 Oct 15, 2025
17 checks passed
@dagardner-nv dagardner-nv deleted the david-remove-1.3-ex branch October 15, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willkill07 willkill07 willkill07 approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels

breaking Breaking change doc Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dagardner-nv @willkill07