Upload test results to codecov (#699)

dagardner-nv · web-flow · commit 738324b55a54 · 2025-08-25T14:59:58.000Z
* Create an explicit directory for test reports rather than the workspace-tmp dir which might contain other files * Use the codecov action to perform the uploading. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. ## Summary by CodeRabbit - Tests - Test reports are now saved in a dedicated reports directory with filenames that include runtime details (architecture and Python version) for easier traceability. - Chores - Continuous integration now uploads coverage to Codecov with stricter failure handling and consistent behavior even if tests fail. - CI propagates environment metadata (architecture and Python version) across steps and standardizes report paths. - Required secrets are passed securely to the workflow. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Will Killian (https://github.com/willkill07) URL: #699
diff --git a/.github/workflows/ci_pipe.yml b/.github/workflows/ci_pipe.yml
@@ -39,6 +39,9 @@ on:
         description: 'The base SHA of the PR'
         required: true
         type: string
+    secrets:
+      CODECOV_TOKEN:
+        required: true
 
 # We only support ubuntu, so bash is the default
 defaults:
@@ -109,6 +112,10 @@ jobs:
           - python-version: "3.12"
             container: ${{ inputs.py_12_container }}
 
+    env:
+      CI_PYTHON_VERSION: ${{ matrix.python-version }}
+      CI_ARCH: ${{ matrix.arch }}
+
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -127,9 +134,20 @@ jobs:
         if: ${{ always() }}
         with:
           name: "test-results-${{ matrix.arch }}-py${{ matrix.python-version }}"
-          path: "${{ github.workspace }}/tmp/*.xml"
+          path: "${{ github.workspace }}/tmp/reports/*.xml"
           if-no-files-found: error
-
+      - name: Upload coverage to Codecov
+        uses: codecov/codecov-action@v5
+        # Upload test results even if the tests fail
+        if: ${{ always() }}
+        with:
+          directory: "${{ github.workspace }}/tmp/reports"
+          env_vars: CI_ARCH,CI_PYTHON_VERSION
+          fail_ci_if_error: true
+          flags: unittests
+          name: nat-code-cov-${{ matrix.arch }}-py${{ matrix.python-version }}
+          token: ${{ secrets.CODECOV_TOKEN }}
+          verbose: true
 
   documentation:
     name: Documentation
diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml
@@ -85,3 +85,5 @@ jobs:
       # Info about the PR. Empty for non PR branches. Useful for extracting PR number, title, etc.
       pr_info: ${{ needs.prepare.outputs.pr_info }}
       base_sha: ${{ needs.prepare.outputs.base_sha }}
+    secrets:
+      CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
diff --git a/ci/scripts/github/tests.sh b/ci/scripts/github/tests.sh
@@ -19,6 +19,8 @@ set -e
 GITHUB_SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"
 
 source ${GITHUB_SCRIPT_DIR}/common.sh
+export REPORTS_DIR=${WORKSPACE_TMP}/reports
+mkdir -p ${REPORTS_DIR}
 get_lfs_files
 
 create_env group:dev extra:all
@@ -27,9 +29,10 @@ rapids-logger "Git Version: $(git describe)"
 rapids-logger "Running tests with Python version $(python --version) and pytest version $(pytest --version) on $(arch)"
 set +e
 
-pytest --junit-xml=${WORKSPACE_TMP}/report_pytest.xml \
+REPORT_IDENT_SLUG="$(arch)-py${PYTHON_VERSION}"
+pytest --junit-xml=${REPORTS_DIR}/report-${REPORT_IDENT_SLUG}_pytest.xml \
        --cov=nat --cov-report term-missing \
-       --cov-report=xml:${WORKSPACE_TMP}/report_pytest_coverage.xml
+       --cov-report=xml:${REPORTS_DIR}/report-${REPORT_IDENT_SLUG}_pytest_coverage.xml
 PYTEST_RESULTS=$?
 
 exit ${PYTEST_RESULTS}
