Skip to content

feat(fern): adopt global-theme nvidia, remove per-repo theme assets#1320

Merged
lalitadithya merged 1 commit into
NVIDIA:mainfrom
pdmack:pdmack/fern-global-theme
May 20, 2026
Merged

feat(fern): adopt global-theme nvidia, remove per-repo theme assets#1320
lalitadithya merged 1 commit into
NVIDIA:mainfrom
pdmack:pdmack/fern-global-theme

Conversation

@pdmack

@pdmack pdmack commented May 20, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary

Switch from per-repo custom theme to Fern's shared global-theme: nvidia. Net deletion: 8 files touched, 6 deleted entirely (-1126 lines).

Follows the pattern established in topograph PR #339.

Deleted (now provided by the global theme):

  • fern/assets/NVIDIA_dark.svg, NVIDIA_light.svg, NVIDIA_symbol.svg
  • fern/components/CustomFooter.tsx, BadgeLinks.tsx
  • fern/main.css

Removed from docs.yml (replaced by global-theme: nvidia):

  • footer:, layout:, colors:, theme:, logo: image paths, favicon:, js:, css:, experimental: blocks

Kept: logo.href + logo.right-text, navbar-links, redirects

Fern CLI: bumped from 4.42.1 to 5.30.2 (required for global-theme support)

Validated with fern check and local fern docs dev preview.

Type of Change

  • 🔧 Refactoring
  • 🔨 Build/CI

Component(s) Affected

  • Documentation/CI

Testing

  • Manual testing completed
  • No breaking changes (or documented)

Checklist

  • Self-review completed
  • Ready for review

Summary by CodeRabbit

  • Refactor

    • Removed footer component from site display
    • Removed badge links component
    • Transitioned to NVIDIA global theme system with simplified styling configuration

  • Chores

    • Updated to version 5.30.2

Review Change Stack

@pdmack @claude
feat(fern): adopt global-theme nvidia, remove per-repo theme assets
399bc8d 
Switch from per-repo custom theme to Fern's shared global-theme: nvidia.
Deletes SVG assets, CustomFooter, BadgeLinks, main.css, and all
layout/colors/logo/js/css config from docs.yml. Bumps Fern CLI from
4.42.1 to 5.30.2 (required for global-theme support).

Follows the pattern established in topograph PR NVIDIA#339.

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
@coderabbitai

coderabbitai Bot commented May 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2b77298f-0345-47b3-9728-3ede607586a6

📥 Commits

Reviewing files that changed from the base of the PR and between d2ccc54 and 399bc8d.

⛔ Files ignored due to path filters (3)
  • fern/assets/NVIDIA_dark.svg is excluded by !**/*.svg
  • fern/assets/NVIDIA_light.svg is excluded by !**/*.svg
  • fern/assets/NVIDIA_symbol.svg is excluded by !**/*.svg
📒 Files selected for processing (5)
  • fern/components/BadgeLinks.tsx
  • fern/components/CustomFooter.tsx
  • fern/docs.yml
  • fern/fern.config.json
  • fern/main.css
💤 Files with no reviewable changes (3)
  • fern/main.css
  • fern/components/BadgeLinks.tsx
  • fern/components/CustomFooter.tsx
📝 Walkthrough

Walkthrough

This PR upgrades the Fern documentation generator from v4.42.1 to v5.30.2 and adopts NVIDIA's built-in theme. Custom React components (BadgeLinks, CustomFooter) and the entire custom CSS stylesheet are removed, replacing them with the new version's theme infrastructure and built-in styling.

Changes

Fern Version Upgrade and Theme Migration

Layer / File(s) Summary
Fern version upgrade
fern/fern.config.json		 Fern version bumped from 4.42.1 to 5.30.2.
NVIDIA theme adoption and configuration simplification
fern/docs.yml		 Global NVIDIA theme enabled and site configuration simplified: logo block reduced to href and right-text, custom footer/layout/experimental/colors/theme/favicon/js/css settings removed, redirects and navbar-links reorganized. Deleted custom components fern/components/BadgeLinks.tsx, fern/components/CustomFooter.tsx, and entire stylesheet fern/main.css (866 lines).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested reviewers

  • lalitadithya

Poem

🐰 The NVIDIA theme's here to stay,
Custom CSS fades away,
BadgeLinks and footers take their bow,
A cleaner docs config now!
Version five shines bright and bold,
Modernizing themes of old. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adopting Fern's global-theme nvidia setting and removing repository-specific theme assets, which aligns with the primary objectives of this refactoring PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

Comment @coderabbitai help to get the list of available commands and usage tips.

@lalitadithya lalitadithya enabled auto-merge (squash) May 20, 2026 19:28
@github-actions

github-actions Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

🌿 Fern Docs Preview: https://nvidia-preview-pull-request-1320.docs.buildwithfern.com/nvsentinel

@lalitadithya lalitadithya merged commit 29208f5 into NVIDIA:main May 20, 2026
53 checks passed
@pdmack pdmack deleted the pdmack/fern-global-theme branch May 20, 2026 23:30
@pdmack pdmack mentioned this pull request May 21, 2026
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lalitadithya lalitadithya lalitadithya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pdmack @lalitadithya