Skip to content

Make sure the Simulator supports alternative config formats#1923

Merged
chesterxgchen merged 7 commits intoNVIDIA:mainfrom
chesterxgchen:simulator
Aug 12, 2023
Merged

Make sure the Simulator supports alternative config formats#1923
chesterxgchen merged 7 commits intoNVIDIA:mainfrom
chesterxgchen:simulator

Conversation

@chesterxgchen
Copy link
Copy Markdown
Collaborator

@chesterxgchen chesterxgchen commented Aug 11, 2023 •
edited
Loading

Description

Allow Simulator to support alternative configuration format. Primarily in job meta validation in the zip file.

A few sentences describing the changes proposed in this pull request.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@chesterxgchen chesterxgchen changed the title Make sure the Simulator support alternative config formats Make sure the Simulator supports alternative config formats Aug 11, 2023
YuanTingHsieh
YuanTingHsieh reviewed Aug 12, 2023
View reviewed changes
@chesterxgchen chesterxgchen mentioned this pull request Aug 12, 2023
Merged
6 tasks
YuanTingHsieh
YuanTingHsieh approved these changes Aug 12, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@chesterxgchen
Copy link
Copy Markdown
Collaborator Author

chesterxgchen commented Aug 12, 2023

/build

@chesterxgchen chesterxgchen merged commit d709a22 into NVIDIA:main Aug 12, 2023
@chesterxgchen chesterxgchen deleted the simulator branch November 3, 2023 03:09
holgerroth pushed a commit to holgerroth/NVFlare that referenced this pull request Dec 4, 2023
@chesterxgchen
Make sure the Simulator supports alternative config formats (NVIDIA#1923
258fd63 
)

* simulator fix

* make sure simulator handle alternative meta.json|conf|yml

* style

* break out the loop once found

* break out the loop once found

* update

* normalize file path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

@yhwen yhwen Awaiting requested review from yhwen

@IsaacYangSLA IsaacYangSLA Awaiting requested review from IsaacYangSLA

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chesterxgchen @YuanTingHsieh