Repository navigation
Improve the sharding and shuffling documentation - #6484
Merged
Merged
Conversation
Contributor
 |
JanuszL
reviewed
Sep 14, 2026
Collaborator
Author
|
!build |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Collaborator
|
CI MESSAGE: [67804207]: BUILD STARTED |
Collaborator
|
CI MESSAGE: [67804207]: BUILD FAILED |
JanuszL
reviewed
Sep 14, 2026
| keeps shard membership stable across epochs, so these options cannot be enabled together. | ||
|
|
||
| Whether ``random_shuffle`` can be combined with ``shuffle_after_epoch`` depends on the reader. | ||
| See the reader's ``shuffle_after_epoch`` argument documentation for supported combinations. |
JanuszL
approved these changes
Sep 14, 2026
Collaborator
|
CI MESSAGE: [67804207]: BUILD PASSED |
jantonguirao
approved these changes
Sep 15, 2026
Signed-off-by: Rostan Tabet <[email protected]>
…e the relevant page Signed-off-by: Rostan Tabet <[email protected]>
rostan-t
force-pushed
the
shard-shuffling-doc
branch
from
September 15, 2026 16:28
9bbff05 to
64c410a
Compare
4 of 18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
The documentation didn't clearly state the differences between
random_shuffleandshuffle_after_epoch, nor which readers allow combining them.This PR adds a section about shuffling to clarify the related arguments in readers.
Additional information:
Affected modules and functionalities:
Sharding documentation becomes Sharding and Shuffling documentation.
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-2763