Repository navigation
Fix webdataset python index creation script - #4226
Merged
Merged
Conversation
Contributor
Author
|
!build |
Collaborator
|
CI MESSAGE: [5833825]: BUILD STARTED |
Collaborator
|
CI MESSAGE: [5833825]: BUILD FAILED |
JanuszL
force-pushed
the
fix_wds_idx_gen
branch
from
September 4, 2022 21:55
4b24fdb to
c32c5cb
Compare
Contributor
Author
|
!build |
Collaborator
|
CI MESSAGE: [5833923]: BUILD STARTED |
Collaborator
|
CI MESSAGE: [5833923]: BUILD FAILED |
- fixes wrong offset calculation in webdataset python index creation script. The right formula for the data offset calculation should be the output of (`block-number` + 1) * 512 while it was calculated as (next ``block-number`) * 512 - data size (what doesn't work when the first entry is preceded by additional data like in POSIX.1-2001 archive Signed-off-by: Janusz Lisiecki <[email protected]>
JanuszL
force-pushed
the
fix_wds_idx_gen
branch
from
September 5, 2022 07:41
c32c5cb to
406ecf0
Compare
Contributor
Author
|
!build |
Collaborator
|
CI MESSAGE: [5836203]: BUILD STARTED |
Collaborator
|
CI MESSAGE: [5836203]: BUILD PASSED |
klecki
reviewed
Sep 5, 2022
klecki
reviewed
Sep 5, 2022
Signed-off-by: Janusz Lisiecki <[email protected]>
Contributor
Author
|
!build |
Collaborator
|
CI MESSAGE: [5844338]: BUILD STARTED |
klecki
approved these changes
Sep 6, 2022
Collaborator
|
CI MESSAGE: [5844338]: BUILD PASSED |
awolant
approved these changes
Sep 8, 2022
3 of 18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
index creation script. The right formula for the data
offset calculation should be the output of (
block-number+ 1) * 512while it was calculated as (next ``block-number`) * 512 - data size
(what doesn't work when the first entry is preceded by additional data
like in POSIX.1-2001 archive
Signed-off-by: Janusz Lisiecki [email protected]
Category:
Bug fix (non-breaking change which fixes an issue)
Description:.
index creation script. The right formula for the data
offset calculation should be the output of (
block-number+ 1) * 512while it was calculated as (next ``block-number`) * 512 - data size
(what doesn't work when the first entry is preceded by additional data
like in POSIX.1-2001 archive
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A
Relates to #4215