Add project urls to setup.py for pypi page #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Could try it out on |
mdeceglie
approved these changes
Dec 29, 2020
Collaborator
mdeceglie
left a comment
mdeceglie
left a comment
There was a problem hiding this comment.
LGTM. Let's just go for it on our next release and patch things if it breaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code changes are covered by testsNew functions added to__init__.pyAPI.rst is up to date, along with other sphinx docs pagesExample notebooks are rerun and differences in results scrutinizedUpdated changelogPyPI can be configured to display various URLs through
setup.py(docs). Here's an example:I'm not sure where the logic for matching icons to text (the dict keys) is documented, if anywhere, so I'm just copying pandas's descriptions. One thing to note: apparently the display order on pypi.org is reversed from the dictionary order here (see pypi/warehouse#3097).