Add -DPORTABLE_KINDS option to autotools and cmake build system#1572
Merged
rem1776 merged 3 commits intoNOAA-GFDL:mainfrom Aug 27, 2024
Merged
Add -DPORTABLE_KINDS option to autotools and cmake build system#1572rem1776 merged 3 commits intoNOAA-GFDL:mainfrom
rem1776 merged 3 commits intoNOAA-GFDL:mainfrom
Conversation
rem1776
previously approved these changes
Aug 13, 2024
Contributor
|
@mlee03 - please make these same changes to the CMake build system as well |
Contributor
Author
|
@bensonr, made the changes for cmake! |
bensonr
approved these changes
Aug 13, 2024
rem1776
approved these changes
Aug 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR,
configure.acfile has been modified to accept--enable-portable-kindsargument during configuration.This option will define
-DPORTABLE_KINDS=1for compilation and FMS variables will be compiled withiso_c_bindingkind parameters.The same change has been made to CMakeLists.txt where users can supply the argument
-DPORTABLE_KINDS=onto cmakeFixes #1571
How Has This Been Tested?
FMS compiles with -DPORTABLE_KINDS=1 when
./configure --enable-portable-kindswith gcc on the amdbox.Checklist:
make distcheckpasses