src/NLog/Targets/AsyncTaskTarget.cs (1)

414-420: Consider the implications of silently skipping enqueue when cont is null.

The null check correctly addresses the nullable warning since WaitCallback has signature (object? state). However, when cont is null, the code now skips enqueueing but still proceeds to change the timer (line 419). This could lead to a flush operation completing without the continuation being invoked.

Given that asyncContinuation passed at line 422 is non-nullable, cont should never be null in practice. The current fix is acceptable as defensive coding, but consider whether a no-op early return might be cleaner if cont is null:

♻️ Optional: Early return for clarity

 _flushEventsInQueueDelegate = (cont) =>
 {
-    if (cont != null)
-        _requestQueue.Enqueue(new AsyncLogEventInfo(_flushEvent, (AsyncContinuation)cont));
+    if (cont is null)
+        return; // Should not happen - asyncContinuation is non-nullable
+    _requestQueue.Enqueue(new AsyncLogEventInfo(_flushEvent, (AsyncContinuation)cont));
     lock (SyncRoot)
         _lazyWriterTimer.Change(0, Timeout.Infinite);
 };

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/NLog/Targets/AsyncTaskTarget.cs` around lines 414 - 420, The current
delegate _flushEventsInQueueDelegate checks for cont == null and skips enqueuing
but still calls _lazyWriterTimer.Change, which can schedule a flush without a
continuation; change the delegate to perform an early return when cont is null
(i.e., if (cont == null) return;) so the timer is not started unless you
actually enqueued AsyncLogEventInfo(_flushEvent, (AsyncContinuation)cont) into
_requestQueue; keep the defensive null check since asyncContinuation is
non-nullable in callers, and reference _flushEventsInQueueDelegate,
_requestQueue.Enqueue, AsyncLogEventInfo, _flushEvent and
_lazyWriterTimer.Change to locate the code to modify.