tests/NLog.UnitTests/Config/PropertyTypeConverterTests.cs (1)

226-236: Cover the raw DateTime -> DateTimeOffset fallback as well.

This test only exercises the formatted IFormattable path. The new special-case on Line 164 in src/NLog/Config/PropertyTypeConverter.cs is a separate branch, so adding a no-format case here would keep that regression fix protected too.

➕ Suggested test coverage

 [Fact]
 public void Convert_DateTimeToDateTimeOffset()
 {
     // Act
     var dateTime = new DateTime(1970, 1, 1, 0, 0, 0, DateTimeKind.Utc);
     var result = _sut.Convert(dateTime, typeof(DateTimeOffset), "o", null);
 
     // Assert
     var resultTyped = Assert.IsType<DateTimeOffset>(result);
     Assert.Equal(dateTime, resultTyped.DateTime);
 }
+
+[Fact]
+public void Convert_DateTimeToDateTimeOffsetWithoutFormat()
+{
+    // Act
+    var dateTime = new DateTime(1970, 1, 1, 0, 0, 0, DateTimeKind.Utc);
+    var result = _sut.Convert(dateTime, typeof(DateTimeOffset), null, null);
+
+    // Assert
+    var resultTyped = Assert.IsType<DateTimeOffset>(result);
+    Assert.Equal(dateTime, resultTyped.DateTime);
+}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/NLog.UnitTests/Config/PropertyTypeConverterTests.cs` around lines 226 -
236, Add a second assertion in the Convert_DateTimeToDateTimeOffset test to
exercise the non-formattable fallback path by calling _sut.Convert with the same
DateTime and target type typeof(DateTimeOffset) but with format set to null (or
an empty string), then assert the result is a DateTimeOffset and that its
DateTime equals the original dateTime; this ensures the raw
DateTime->DateTimeOffset branch in PropertyTypeConverter.Convert is covered in
addition to the formatted IFormattable path.

tests/NLog.UnitTests/Config/PropertyTypeConverterTests.cs (1)

226-236: Add coverage for the no-format branch.

This test only exercises the formatted IFormattable path. The new raw DateTime -> DateTimeOffset fallback on Lines 162-163 in src/NLog/Config/PropertyTypeConverter.cs is still unpinned.

🧪 Suggested companion test

         [Fact]
         public void Convert_DateTimeToDateTimeOffset()
         {
             // Act
             var dateTime = new DateTime(1970, 1, 1, 0, 0, 0, DateTimeKind.Utc);
             var result = _sut.Convert(dateTime, typeof(DateTimeOffset), "o", null);

             // Assert
             var resultTyped = Assert.IsType<DateTimeOffset>(result);
             Assert.Equal(dateTime, resultTyped.DateTime);
         }
+
+        [Fact]
+        public void Convert_DateTimeToDateTimeOffsetWithoutFormat()
+        {
+            // Act
+            var dateTime = new DateTime(1970, 1, 1, 0, 0, 0, DateTimeKind.Utc);
+            var result = _sut.Convert(dateTime, typeof(DateTimeOffset), null, null);
+
+            // Assert
+            var resultTyped = Assert.IsType<DateTimeOffset>(result);
+            Assert.Equal(dateTime, resultTyped.DateTime);
+        }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/NLog.UnitTests/Config/PropertyTypeConverterTests.cs` around lines 226 -
236, Add a companion unit test that exercises the "no-format" fallback in
PropertyTypeConverter.Convert by calling _sut.Convert with a DateTime (same
sample: new DateTime(1970,1,1,..., DateTimeKind.Utc)) and passing null for the
format parameter (third arg) instead of "o"; assert the returned object is a
DateTimeOffset (use Assert.IsType<DateTimeOffset>) and that its DateTime equals
the original DateTime. Name the test clearly (e.g.,
Convert_DateTimeToDateTimeOffset_NoFormat) and mirror the existing assertions
used in Convert_DateTimeToDateTimeOffset.

tests/NLog.UnitTests/Config/PropertyTypeConverterTests.cs (1)

226-236: Consider a more explicit assertion for clarity.

The assertion Assert.Equal(dateTime.Date, resultTyped.DateTime) works but is semantically confusing—it compares a date-at-midnight with the full DateTime from DateTimeOffset. Since the "yyyy-MM-dd" format intentionally discards time, asserting against the expected concrete value makes the intent clearer:

-            Assert.Equal(dateTime.Date, resultTyped.DateTime);
+            Assert.Equal(new DateTime(1970, 1, 1), resultTyped.DateTime);

Alternatively, consider adding an offset assertion if that's relevant to the bug fix (e.g., Assert.Equal(TimeSpan.Zero, resultTyped.Offset) if UTC is expected).

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/NLog.UnitTests/Config/PropertyTypeConverterTests.cs` around lines 226 -
236, The test Convert_DateTimeToDateTimeOffset is asserting dateTime.Date
against resultTyped.DateTime which is confusing; update the assertion to compare
against an explicit expected DateTimeOffset constructed from dateTime.Date (or
compare resultTyped.DateTime to dateTime.Date and resultTyped.Offset to the
expected offset) so the intent of the "yyyy-MM-dd" format is clear—modify the
assertions in the Convert_DateTimeToDateTimeOffset test that inspect
_sut.Convert(...) and the resultTyped variable to use an explicit expected
DateTimeOffset (and optionally assert resultTyped.Offset, e.g., TimeSpan.Zero if
UTC is expected).

tests/NLog.UnitTests/Config/PropertyTypeConverterTests.cs (1)

238-248: Consider adding an assertion for offset preservation.

The test validates that the DateTime value is preserved, but doesn't verify that the DateTimeKind.Utc is correctly converted to a zero UTC offset. DateTime.Equals compares only Ticks, not Kind.

🔧 Suggested enhancement

             // Assert
             var resultTyped = Assert.IsType<DateTimeOffset>(result);
             Assert.Equal(dateTime, resultTyped.DateTime);
+            Assert.Equal(TimeSpan.Zero, resultTyped.Offset);
         }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/NLog.UnitTests/Config/PropertyTypeConverterTests.cs` around lines 238 -
248, The test Convert_DateTimeToDateTimeOffset_NoFormat should also assert that
the UTC kind is preserved as a zero offset; after calling _sut.Convert(dateTime,
typeof(DateTimeOffset), null, null) and casting to resultTyped (DateTimeOffset),
add an assertion that resultTyped.Offset == TimeSpan.Zero (or that
resultTyped.ToUniversalTime().Ticks equals dateTime.ToUniversalTime().Ticks) so
the conversion from DateTime with DateTimeKind.Utc yields a DateTimeOffset with
zero UTC offset.