set names for cascade's tokio threads#356
Merged
tertsdiepraam merged 3 commits intomainfrom Nov 21, 2025
Merged
Conversation
tertsdiepraam
changed the title
tertsdiepraam
force-pushed
the
thread-names
branch
from
bf49c5d to
ff7831f
Compare
ximon18
approved these changes
Nov 20, 2025
Member
|
What about threads used by the parallel signing code? |
tertsdiepraam
force-pushed
the
thread-names
branch
from
ff7831f to
f61f4e8
Compare
Contributor
Author
Seems to work based on a quick look at htop |
Member
|
Nice. Should we name the rayon threads differently, e.g. |
ximon18
approved these changes
Nov 21, 2025
bal-e
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would've loved to set names for the tasks but that is still unstable in tokio. Instead, we just change the names of the treads. This makes it less important but maybe still a nice improvement.
Closes #317