Propagate policy changes to keyset.#355
Merged
Philip-NLnetLabs merged 1 commit intomainfrom Nov 21, 2025
Merged
Conversation
bal-e
reviewed
Nov 19, 2025
Contributor
bal-e
left a comment
bal-e
left a comment
There was a problem hiding this comment.
The code looks great! Just double-checking: were you able to test that this propagates policy changes properly? E.g. to update key expiry times?
Member
Author
|
Yes, I changed the algorithm and checked that it was reflected in the keyset config. Cascade also shows the keyset commands it is running. |
bal-e
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.