Log review script stdout and stderr to the log target#281
Merged
tertsdiepraam merged 2 commits intomainfrom Oct 29, 2025
Merged
Log review script stdout and stderr to the log target#281tertsdiepraam merged 2 commits intomainfrom
tertsdiepraam merged 2 commits intomainfrom
Conversation
bal-e
approved these changes
Oct 28, 2025
Contributor
bal-e
left a comment
bal-e
left a comment
There was a problem hiding this comment.
Looks good! I think .next_line() is allocating a new String every time you call it, but it's not a real issue. LGTM.
Contributor
Author
|
I was hoping LLVM would just fix that for me :) |
tertsdiepraam
force-pushed
the
review-logging
branch
from
bdc58f8 to
02a00de
Compare
Contributor
Author
|
Oh I need to remove that test script |
AlexanderBand
pushed a commit
that referenced
this pull request
Oct 30, 2025
* log review script stdout and stderr to the log target * remove test script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #278