Conversation
bal-e
force-pushed
the
negative-nsec-counts
branch
from
83b87d4 to
4900cd4
Compare
| .await | ||
| .unwrap(); | ||
| let sort_time = sort_start.elapsed(); | ||
| let unsigned_rr_count = records.len(); |
Contributor
There was a problem hiding this comment.
Right, so the thing that solves this is that you recompute the count after putting it in the zonetree? Is any of the other code relevant to this?
Contributor
Author
There was a problem hiding this comment.
Yeah! These values are only used for statistics. We will probably overhaul the whole zone storage and signing pipeline eventually -- this is a small fix to get things right for now.
'unsigned_rr_count' was computed before deduplication, and so contained an excessive number of records. The variable is now reset after deduplication, thereby presenting accurate numbers in the signing logs.
bal-e
force-pushed
the
negative-nsec-counts
branch
from
adf96d5 to
261db8b
Compare
Contributor
Author
|
Rebased onto |
tertsdiepraam
approved these changes
Oct 28, 2025
Contributor
tertsdiepraam
left a comment
tertsdiepraam
left a comment
There was a problem hiding this comment.
A comment would be nice but it's fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #268.