Do not halt pipeline on keyset errors#265
Merged
tertsdiepraam merged 2 commits intomainfrom Oct 24, 2025
Merged
Conversation
Member
|
In my opinion, CLI commands that directly translate to keyset commands should not affect the pipeline. The full error has to be returned to the user of the CLI command. If there is a structural error, then the next keyset cron command will fail and that will be the right time to stop the pipeline. |
Contributor
Author
|
@Philip-NLnetLabs so we should remove the TODO? |
mozzieongit
approved these changes
Oct 24, 2025
bal-e
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A step to resolving: #187
Keyset key roll errors are usually not fatal because they stem from simple user error. If there should be something that causes an actual error, we should adapt keyset to return more informative exit codes (e.g. 0 is success, 1 is fatal, 2 is user error, or something like that), but this PR is simply ignoring these errors.
It's hard to say whether this is enough for #187. The other issue mentioned there is a failing review script, which is already a soft error and therefore seems fine as it is.