Conversation
Previously, the configuration file was stored in state and only reloaded in response to 'cascade reload'. Users found this behaviour confusing, and it complicates some internal logic, so we're changing it to the standard approach.
mozzieongit
approved these changes
Oct 21, 2025
Member
mozzieongit
left a comment
mozzieongit
left a comment
There was a problem hiding this comment.
Just missing a few doc changes, but I would have a few commits prepared for that. Should I push them or make a new PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had initially design the config system with the idea that Cascade can restart at any time and continue exactly as it was before. But this idea has unintuitive effects, and we've heard from users that they expect restarting the daemon will reload the configuration file. It also caused confusing problems with binding privileged ports. This PR restores the standard behavior.
Solves #192. Should help with #226.