Allow disabling colors via anstream#256
Merged
tertsdiepraam merged 1 commit intomainfrom Oct 21, 2025
Merged
Conversation
bal-e
approved these changes
Oct 20, 2025
Contributor
bal-e
left a comment
bal-e
left a comment
There was a problem hiding this comment.
Looks good! Unrelated note: at some point we probably want to separate the CLI and the daemon into properly independent crates.
tertsdiepraam
force-pushed
the
disable-color-the-stupid-way
branch
2 times, most recently
from
faf435b to
3238fa6
Compare
bal-e
requested changes
Oct 20, 2025
tertsdiepraam
force-pushed
the
disable-color-the-stupid-way
branch
from
3238fa6 to
9f031a6
Compare
bal-e
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #243
Use
anstreamto disable terminal colors automagically. I made the regularprintlnandeprintlndisallowed in clippy so that we are forced to use the anstream versions. This required me to make my own wrappers that call the anstream macros with an#[allow(clippy::disallowed_macros)], because they expand to something that callsprintln/eprintln.Note that
anstreamis already in our dependency tree viaclap.