Merged
Conversation
ximon18
reviewed
Oct 16, 2025
doc/manual/source/key-management.rst
Outdated
| As part of maintaining a set of keys, the key manager also provides key rolls. | ||
|
|
||
| Cascade uses an external key manager. | ||
| The program that key management is called ```dnst``` and the actual |
Member
There was a problem hiding this comment.
Suggested change
| The program that key management is called ```dnst``` and the actual | |
| The program that manages keys is called ```dnst``` and the actual |
ximon18
reviewed
Oct 16, 2025
doc/manual/source/key-management.rst
Outdated
| As part of maintaining a set of keys, the key manager also provides key rolls. | ||
|
|
||
| Cascade uses an external key manager. | ||
| The program that key management is called ```dnst``` and the actual |
Member
There was a problem hiding this comment.
Suggested change
| The program that key management is called ```dnst``` and the actual | |
| The program that key management is called ``dnst`` and the actual |
ximon18
reviewed
Oct 16, 2025
Member
|
I guess this means |
ximon18
reviewed
Oct 16, 2025
ximon18
reviewed
Oct 16, 2025
Member
Author
|
I think so. It seems empty. We can have import keys in three places: the key manager, the cli commands and the migration guide(s). |
ximon18
reviewed
Oct 16, 2025
ximon18
reviewed
Oct 16, 2025
| @@ -101,31 +92,29 @@ Examples of things we're interested in: | |||
| :name: toc-guides | |||
|
|
|||
| importing-keys | |||
Member
There was a problem hiding this comment.
Suggested change
| importing-keys |
Member
We still need a "next step" in the guide that takes you through actually importing keys, which this page is not. |
Co-authored-by: Alex Band <[email protected]> Co-authored-by: Ximon Eighteen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.