Improve documentation about review hooks#216
Merged
mozzieongit merged 3 commits intomainfrom Oct 14, 2025
Merged
Conversation
mozzieongit
commented
Oct 14, 2025
ximon18
reviewed
Oct 14, 2025
ximon18
reviewed
Oct 14, 2025
ximon18
reviewed
Oct 14, 2025
Comment on lines
+65
to
+70
| if [ "$1" = "unsigned" ]; then | ||
| # validns does not handle Ed25519 | ||
| validns -z "${CASCADE_ZONE}" -p all ${tmp_zone} | ||
| else | ||
| dnssec-verify -q -o "${CASCADE_ZONE}" ${tmp_zone} | ||
| fi |
Contributor
There was a problem hiding this comment.
This is interesting. Makes me wonder whether we even need 2 separate hooks. Though I guess that could still be useful in some cases.
Member
Author
There was a problem hiding this comment.
What do you mean by needing 2 separate hooks? The separate hooks are called at different stages in the pipeline, so need to be separate in the policy
Member
There was a problem hiding this comment.
Two separate hooks yes, two separate scripts to be called by the hooks, no.
AlexanderBand
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #198