Add CASCADE_SERVER_IP and _PORT env variables for review hooks#213
Merged
mozzieongit merged 4 commits intomainfrom Oct 14, 2025
Merged
Add CASCADE_SERVER_IP and _PORT env variables for review hooks#213mozzieongit merged 4 commits intomainfrom
mozzieongit merged 4 commits intomainfrom
Conversation
ximon18
approved these changes
Oct 14, 2025
Member
ximon18
left a comment
ximon18
left a comment
There was a problem hiding this comment.
LGTM. Will you update the docs and config file comments to match?
Member
Author
Will do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is relevant for people using POSIX
sh, which has no easy integrated way of splitting out the port from the_SERVERvariable if it is an IPv6 address. (See #198)Currently, this PR just adds the two other variables. We can leave the
CASCADE_SERVERvariable for convenience, or remove it to prevent clutter. Any preference?Closes: #201