Skip to content

feat(module: drawer): support closeAll method#4231

Closed
tirelyl wants to merge 5 commits intoNG-ZORRO:masterfrom
tirelyl:drawer-control-service
Closed

feat(module: drawer): support closeAll method#4231
tirelyl wants to merge 5 commits intoNG-ZORRO:masterfrom
tirelyl:drawer-control-service

Conversation

@tirelyl
Copy link
Copy Markdown
Contributor

@tirelyl tirelyl commented Sep 26, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2965

What is the new behavior?

add new method closeAll for drawer component

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 26, 2019 •
edited
Loading

Deploy preview for ng-zorro-master ready!

Built with commit ffeaa58

https://deploy-preview-4231--ng-zorro-master.netlify.com

@wzhudev wzhudev requested a review from hsuanxyz September 29, 2019 01:02
@weekly-digest weekly-digest Bot mentioned this pull request Sep 29, 2019
Closed
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 4, 2019 •
edited
Loading

Codecov Report

Merging #4231 into master will decrease coverage by 0.06%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4231      +/-   ##
==========================================
- Coverage    92.3%   92.23%   -0.07%     
==========================================
  Files         519      521       +2     
  Lines       10963    10991      +28     
  Branches     1984     1991       +7     
==========================================
+ Hits        10119    10138      +19     
- Misses        420      423       +3     
- Partials      424      430       +6
Impacted Files Coverage Δ
components/drawer/nz-drawer.module.ts 100% <ø> (ø) ⬆️
...ponents/drawer/nz-drawer-control.service.module.ts 100% <100%> (ø)
components/drawer/nz-drawer.component.ts 96.4% <100%> (+0.07%) ⬆️
components/drawer/nz-drawer.service.ts 96.29% <50%> (-3.71%) ⬇️
components/drawer/nz-drawer-control.service.ts 60.86% <60.86%> (ø)
components/calendar/month-table.component.ts 91.42% <0%> (ø) ⬆️
...date-picker/lib/calendar/today-button.component.ts 88.23% <0%> (ø) ⬆️
components/page-header/nz-page-header.component.ts 100% <0%> (ø) ⬆️
components/date-picker/picker.component.ts 97.22% <0%> (ø) ⬆️
components/breadcrumb/nz-breadcrumb.component.ts 89.74% <0%> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 418adb9...6e544c9. Read the comment docs.

@tirelyl tirelyl changed the title WIP: feat(module: drawer): support closeAll method feat(module: drawer): support closeAll method Oct 4, 2019
@weekly-digest weekly-digest Bot mentioned this pull request Oct 6, 2019
Closed
@wzhudev wzhudev mentioned this pull request Oct 7, 2019
Merged
6 tasks
@tirelyl tirelyl force-pushed the drawer-control-service branch from d5f08a7 to 6e544c9 Compare October 8, 2019 01:57
@weekly-digest weekly-digest Bot mentioned this pull request Oct 13, 2019
Closed
vthinkxie
vthinkxie requested changes Oct 14, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tirelyl
thanks for your contribution, the test ci failed, plz rebase onto master and fix it

@tirelyl tirelyl force-pushed the drawer-control-service branch from 6e544c9 to a9231b1 Compare October 16, 2019 06:52
@weekly-digest weekly-digest Bot mentioned this pull request Oct 20, 2019
Closed
@vthinkxie
Copy link
Copy Markdown
Member

vthinkxie commented Jun 11, 2020

Hi, This Pull Request is going to be closed since no update for a long time, feel free to open a new PR if any new update.

@vthinkxie vthinkxie closed this Jun 11, 2020
@tirelyl tirelyl deleted the drawer-control-service branch July 7, 2020 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vthinkxie vthinkxie vthinkxie requested changes

@hsuanxyz hsuanxyz Awaiting requested review from hsuanxyz hsuanxyz is a code owner

Assignees

@hsuanxyz hsuanxyz

Labels

PR: unreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tirelyl @vthinkxie @hsuanxyz