Skip to content

fix for scalar domain ancillaries in netcdfwrite.py#99

Merged
davidhassell merged 1 commit intoNCAS-CMS:masterfrom
davidhassell:write_fix
Nov 16, 2020
Merged

fix for scalar domain ancillaries in netcdfwrite.py#99
davidhassell merged 1 commit intoNCAS-CMS:masterfrom
davidhassell:write_fix

Conversation

@davidhassell
Copy link
Copy Markdown
Contributor

Fixes #98

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 16, 2020

Codecov Report

Merging #99 (fa45c9d) into master (bc1281e) will decrease coverage by 0.01%.
The diff coverage is 66.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   88.52%   88.51%   -0.00%     
==========================================
  Files         101      101              
  Lines        9926     9929       +3     
==========================================
+ Hits         8786     8788       +2     
- Misses       1140     1141       +1     
Flag Coverage Δ
unittests 88.51% <66.67%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cfdm/cfdmimplementation.py 92.79% <50.00%> (-0.46%) ⬇️
cfdm/core/__init__.py 84.10% <100.00%> (ø)
cfdm/read_write/netcdf/netcdfwrite.py 86.29% <100.00%> (ø)
cfdm/read_write/netcdf/netcdfread.py 82.29% <0.00%> (-0.05%) ⬇️
cfdm/core/abstract/propertiesdatabounds.py 91.67% <0.00%> (+2.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc1281e...fa45c9d. Read the comment docs.

@davidhassell davidhassell merged commit 4e55050 into NCAS-CMS:master Nov 16, 2020
@davidhassell davidhassell deleted the write_fix branch November 14, 2022 09:03
@davidhassell davidhassell added the dataset write Relating to writing datasets label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dataset write Relating to writing datasets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Failure when writing a dataset that contains a scalar domain ancillary construct

1 participant