Fix error from Data.second_element for some data shapes #250
Merged
davidhassell merged 2 commits intoNCAS-CMS:mainfrom Mar 26, 2023
Merged
Fix error from Data.second_element for some data shapes #250davidhassell merged 2 commits intoNCAS-CMS:mainfrom
Data.second_element for some data shapes #250davidhassell merged 2 commits intoNCAS-CMS:mainfrom
Conversation
sadielbartholomew
approved these changes
Mar 24, 2023
Member
sadielbartholomew
left a comment
sadielbartholomew
left a comment
There was a problem hiding this comment.
Fixes the issue at hand in a sensible way and adds some testing. I've made one minor suggestion, but all is good, so please merge when ready.
Co-authored-by: Sadie L. Bartholomew <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #249