Skip to content

Drop python 3.6#154

Merged
davidhassell merged 3 commits intoNCAS-CMS:masterfrom
davidhassell:drop-python-3.6
Sep 6, 2021
Merged

Drop python 3.6#154
davidhassell merged 3 commits intoNCAS-CMS:masterfrom
davidhassell:drop-python-3.6

Conversation

@davidhassell
Copy link
Copy Markdown
Contributor

Fixes #139

@davidhassell davidhassell added this to the 1.9.0.0 milestone Aug 26, 2021
@davidhassell davidhassell self-assigned this Aug 26, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 26, 2021

Codecov Report

Merging #154 (e02ad85) into master (ac0bae4) will decrease coverage by 0.11%.
The diff coverage is 76.88%.

❗ Current head e02ad85 differs from pull request most recent head 96db623. Consider uploading reports for the commit 96db623 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
- Coverage   88.75%   88.65%   -0.10%     
==========================================
  Files         101      101              
  Lines       10512    10795     +283     
==========================================
+ Hits         9329     9569     +240     
- Misses       1183     1226      +43     
Flag Coverage Δ
unittests 88.65% <76.88%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cfdm/__init__.py 89.84% <ø> (ø)
cfdm/abstract/implementation.py 100.00% <ø> (ø)
cfdm/auxiliarycoordinate.py 100.00% <ø> (ø)
cfdm/bounds.py 89.80% <ø> (ø)
cfdm/cellmeasure.py 84.38% <ø> (ø)
cfdm/core/abstract/container.py 100.00% <ø> (ø)
cfdm/core/abstract/coordinate.py 92.00% <ø> (+4.00%) ⬆️
cfdm/core/abstract/propertiesdata.py 87.50% <ø> (+1.39%) ⬆️
cfdm/core/functions.py 100.00% <ø> (ø)
cfdm/core/meta/docstringrewrite.py 95.59% <ø> (ø)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54ee3e1...96db623. Read the comment docs.

Copy link
Copy Markdown
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I see you have amended the 'installation' documentation page in 62862e4 and setup.py as part of the corresponding PR too, as I was at first thinking they seemed to be missing. Locally all of the tests pass except for the seg fault which we are aware of (I'm using for filename in test_*.py; do python $filename; done to see around it).

Ideally before or after merging we can add in docstrings to four new test methods from a previous PR, just to get the (now configured quite strictly) pydocstyle hook to pass and therefore the linting job.

@davidhassell davidhassell merged commit d1efe3b into NCAS-CMS:master Sep 6, 2021
@davidhassell davidhassell deleted the drop-python-3.6 branch November 14, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove support for Python 3.6

2 participants