Conversation
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
==========================================
- Coverage 88.75% 88.65% -0.10%
==========================================
Files 101 101
Lines 10512 10795 +283
==========================================
+ Hits 9329 9569 +240
- Misses 1183 1226 +43
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Looks great. I see you have amended the 'installation' documentation page in 62862e4 and setup.py as part of the corresponding PR too, as I was at first thinking they seemed to be missing. Locally all of the tests pass except for the seg fault which we are aware of (I'm using for filename in test_*.py; do python $filename; done to see around it).
Ideally before or after merging we can add in docstrings to four new test methods from a previous PR, just to get the (now configured quite strictly) pydocstyle hook to pass and therefore the linting job.
Fixes #139