Fix bug in cf.read for some PP data with a single vertical level#668
Merged
davidhassell merged 1 commit intoNCAS-CMS:mainfrom Jun 13, 2023
Merged
Fix bug in cf.read for some PP data with a single vertical level#668davidhassell merged 1 commit intoNCAS-CMS:mainfrom
cf.read for some PP data with a single vertical level#668davidhassell merged 1 commit intoNCAS-CMS:mainfrom
Conversation
davidhassell
added
bug
sadielbartholomew
approved these changes
Jun 13, 2023
Member
sadielbartholomew
left a comment
sadielbartholomew
left a comment
There was a problem hiding this comment.
Thought this problem rang a bell...
All good, please merge!
| indices = [(i, rec) for i, rec in enumerate(recs)] | ||
|
|
||
| if z_axis in self.down_axes: | ||
| if nz > 1 and z_axis in self.down_axes: |
Member
There was a problem hiding this comment.
Oops, we should have made this edit as part of the fix for #641 (I explicitly suggested it on the Issue 🤦♀️ ). Sorry I didn't spot that in review for that PR! Either way, getting it added now is better than never 🙂
Collaborator
Author
There was a problem hiding this comment.
Ah - that one's on me, I reckon - sorry for not picking up on it at the time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #667
Prevents
_reorder_z_axisfrom being called when there is only one Z level (and so there is nothing to reorder!).