Fix bounds properties on computed vertical coordinates#627
Merged
davidhassell merged 2 commits intoNCAS-CMS:mainfrom Apr 24, 2023
Merged
Fix bounds properties on computed vertical coordinates#627davidhassell merged 2 commits intoNCAS-CMS:mainfrom
davidhassell merged 2 commits intoNCAS-CMS:mainfrom
Conversation
Member
There was a problem hiding this comment.
I agree with the approach to fix the underlying issue by clearing the inappropriately-inherited properties on the bounds. Fix tested as working locally and via the CI (the few failing jobs are failing on setup issues I shall address elsewhere soon).
I would therefore approve this, but feel I must encourage us to add a test to capture the bug before supporting a merge! If there's good enough reason to skip some new testing along those lines, then fair enough, but do provide a little bit of justification. Then, either way, I'll pop the approval up. Thanks.
Collaborator
Author
|
New test for bounds properties: 4f3edbb |
Collaborator
Author
|
@sadielbartholomew - over to you for sign off on the test method docstrings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #626