Fix for setting bounds with different but equivalent units#418
Merged
davidhassell merged 4 commits intoNCAS-CMS:masterfrom Jul 13, 2022
Merged
Fix for setting bounds with different but equivalent units#418davidhassell merged 4 commits intoNCAS-CMS:masterfrom
davidhassell merged 4 commits intoNCAS-CMS:masterfrom
Conversation
Member
|
Sorry for the late review on this David, it slipped off my radar somehow (probably due to taking the week's leave and then attending a few conferences)! Reviewing imminently... |
sadielbartholomew
approved these changes
Jul 13, 2022
Member
sadielbartholomew
left a comment
sadielbartholomew
left a comment
There was a problem hiding this comment.
All good, capturing the underlying bug, which after looking through the issue and code here I understand to be that the units assigned (with any necessary data conversion) to the coordinate bounds when set (by set_bounds) should have been those consistent with the coordinate data itself, and fixing it in the sensible (and simplest) way.
Please merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #417