Merged
Conversation
sadielbartholomew
approved these changes
May 6, 2022
Member
sadielbartholomew
left a comment
sadielbartholomew
left a comment
There was a problem hiding this comment.
Looks sound, though I have raised one question relating to the status of local test results I am seeing (probably nothing of concern) and one typo. Good to merge once those are considered. Thanks.
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
sadielbartholomew
approved these changes
May 6, 2022
Member
sadielbartholomew
left a comment
sadielbartholomew
left a comment
There was a problem hiding this comment.
Excellent. Please merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly deprecates
varray. There is no generally safe alternative in thedaskworld.Also does a bit of unrelated tidying in
deprecations.py.