dask: Data dump and load serialisations#392
Merged
davidhassell merged 2 commits intoNCAS-CMS:lama-to-daskfrom Apr 26, 2022
Merged
dask: Data dump and load serialisations#392davidhassell merged 2 commits intoNCAS-CMS:lama-to-daskfrom
davidhassell merged 2 commits intoNCAS-CMS:lama-to-daskfrom
Conversation
Member
There was a problem hiding this comment.
All good, though I had one question which may provoke further changes, as below.
- I see that the
loadd=Noneandloads=Nonekeywords remain, along with basic necessary management of those (if loadd is not None:statement and the equivalent), in the constructor method for theDataobject. Is there a reason they have been left in, or can they now be cut too (I suspect they have been missed since they will throw an error as-is for this PR, I believe)?
Collaborator
Author
|
Good spot - those keywords and their associated code have gone: ed0683d |
sadielbartholomew
approved these changes
Apr 26, 2022
Member
sadielbartholomew
left a comment
sadielbartholomew
left a comment
There was a problem hiding this comment.
I have sanity checked the new commit and this is ready to go. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.