dask: Data.to_dask_array#388
Merged
davidhassell merged 5 commits intoNCAS-CMS:lama-to-daskfrom Apr 25, 2022
Merged
Conversation
Member
There was a problem hiding this comment.
All good except that three cases of (_)get_dask seem to remain (as indicated by one test failure in test_Data_reshape), though I suspect they were re-introduced by the latest merge commit rather than missed by you when you did this. Once you blitz those then I am happy for this to be merged:
$ pwd
/home/sadie/cf-python/cf
$ git grep "get_dask"
data/data.py: # return self.get_dask(copy=True)
data/data.py: dx = self._get_dask()
data/data.py: dx = d._get_dask()
data/utils.py: return a.data.get_dask(copy=False)As indicated in our discussion last week, I agree with the API-related decision to standardise to use get_dask_array and not have those extra methods, where the loss of get, set, del symmetry in this case is justified.
Collaborator
Author
|
Thanks, Sadie. Superceded |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The (undocumented) API seems to be
to_dask_array(), e.g. (fromdask.array.asarray) https://github.com/dask/dask/blob/main/dask/array/core.py#L4343Need to think about when to merge this, as it could break other items ...