dask: Data collapse methods and functions#356
dask: Data collapse methods and functions#356davidhassell merged 43 commits intoNCAS-CMS:lama-to-daskfrom
Data collapse methods and functions#356Conversation
|
Hang on - forgot a test .... |
|
OK - good to go. |
|
Another note:
|
sadielbartholomew
left a comment
sadielbartholomew
left a comment
There was a problem hiding this comment.
I'm mid-way through reviewing and everything seems good so far. Thought I'd raise some typos in the meantime, and if you can address the conflict resolutions that would help me to ensure I am reviewing the up-to-date code. Thanks.
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
…on into dask-collapse
sadielbartholomew
left a comment
sadielbartholomew
left a comment
There was a problem hiding this comment.
Overall this is fantastic. The updated code is well-structured and even copes sensibly across all of the statistics (bar those two methods you say are out-of-scope for this PR) for the slightly evil case of a fully-masked array. Great commitment to thorough documentation, too.
I've posed a few questions on minor aspects and suggested fixes for inevitable typos, one of which is in the functional code so is quite crucial to update. Thanks.
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
2 participants
Another hefty PR! Hopefully self explanatory, but these notes might be useful:
Data.squareandData.sqrtbecause they were useful.Data.statsandData.mean_of_upper_decilebefore realising that they can't be tested yet. So these will be dealt with in separate PRs. Feel free to ignore these methods.