Skip to content

Fix autocyclic bug#267

Merged
sadielbartholomew merged 5 commits intoNCAS-CMS:masterfrom
davidhassell:period
Sep 30, 2021
Merged

Fix autocyclic bug#267
sadielbartholomew merged 5 commits intoNCAS-CMS:masterfrom
davidhassell:period

Conversation

@davidhassell
Copy link
Copy Markdown
Collaborator

Fixes #237

Copy link
Copy Markdown
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change is required I think, though the logic does fix the issue at hand so otherwise this is all good.

Copy link
Copy Markdown
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more minor thing, then we're good to merge...

Co-authored-by: Sadie L. Bartholomew <[email protected]>
@sadielbartholomew sadielbartholomew merged commit 66ba336 into NCAS-CMS:master Sep 30, 2021
@davidhassell davidhassell deleted the period branch September 30, 2021 16:28
@davidhassell davidhassell added this to the 3.11.0 milestone Oct 5, 2021
@davidhassell davidhassell added the bug Something isn't working label Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

set period if dimension cyclicity automatically set

2 participants