cfa: remove specific user shebang#14
Merged
davidhassell merged 1 commit intoNCAS-CMS:masterfrom Nov 13, 2019
Merged
Conversation
Collaborator
|
Hi, thanks for spotting this! Your fix will be v3.0.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HI, I was just getting a feel for the codebase & noticed the
cfascript has a specific user/path Python shebang at the very top, before the standard generic user one.I suspect this is left in from a Python 3 porting development stage, as I can't see a purpose it would serve generally, & there is no equivalent Python 2 line in the earlier version of the same script up on Bitbucket.
I thought it would be easier to put in a PR to suggest to remove it than to write up an Issue. Thanks.