Skip to content

[WIP] Update TUV-x examples and tutorial based on feedback#760

Merged
K20shores merged 3 commits intodevelop-603-tuvx-examplesfrom
copilot/sub-pr-758
Jan 30, 2026
Merged

[WIP] Update TUV-x examples and tutorial based on feedback#760
K20shores merged 3 commits intodevelop-603-tuvx-examplesfrom
copilot/sub-pr-758

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 30, 2026

  • Identify documentation inconsistency between C++ header, C interface, and Python bindings
  • Fix C++ header documentation to match C interface and Python bindings format
  • Align dimension label formatting (heating_reaction and dose_rate) with C interface
  • Verify the changes are correct
  • Reply to the comment with the commit hash

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@K20shores K20shores marked this pull request as ready for review January 30, 2026 14:05
@K20shores K20shores merged commit b1bf4ad into develop-603-tuvx-examples Jan 30, 2026
@K20shores K20shores deleted the copilot/sub-pr-758 branch January 30, 2026 14:05
Copilot AI requested a review from K20shores January 30, 2026 14:05
Copilot stopped work on behalf of K20shores due to an error January 30, 2026 14:05
K20shores added a commit that referenced this pull request Jan 30, 2026
* add v5.4 wavelength grid

* add v5.4 height grid

* add profile read function

* add profile data for v5.4

* add remaining profiles

* add v5.4 aerosol radiator

* add draft tuv-x 5.4 example

* add test of tuv 5.4 against standalone tuv-x

* added ts1 config test and example

* add TUV-x yaml configs

* tighten tolerances on tuv-x standalone tests

* allow in-place profile updates

* allow in-place grid element updates

* allow in-place radiator array updates

* start tuv-x jupyter notebook

* add second TUV-x tutorial

* typos

* add tuv-x dockerfile action

* address copilot comments and action failures

* try to address fortran and python action failures

* attempting to pull the fork head instead of main

* Update tutorials/8.tuv-x_standard_configurations.ipynb

Co-authored-by: Kyle Shores <[email protected]>

* merge main into develop-603-tuvx-examples

* packaging configs

* ignoring duplicate named nc files

* Fix memory safety in TUV-x Python bindings for array returns (#759)

* Initial plan

* Fix memory safety issue in TUV-x Python bindings

Allocate output arrays on heap and use py::capsule to manage lifetime.
This prevents dangling pointers when local vectors are destroyed.

Co-authored-by: K20shores <[email protected]>

* Improve exception safety using std::unique_ptr

Use RAII-based memory management with std::unique_ptr instead of raw
pointers to ensure automatic cleanup if exceptions occur during
allocation or array construction.

Co-authored-by: K20shores <[email protected]>

* Fix double-delete issue in ownership transfer

Store data pointers before releasing unique_ptrs to prevent double-delete
if exceptions occur during numpy array construction.

Co-authored-by: K20shores <[email protected]>

* Ensure atomic ownership transfer from capsule to array

Create each numpy array immediately after its capsule to prevent
use-after-free if exceptions occur during array construction.

Co-authored-by: K20shores <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: K20shores <[email protected]>

* [WIP] Update TUV-x examples and tutorial based on feedback (#760)

* Initial plan

* Align Run() docstring array dimensions with C interface and Python bindings

Co-authored-by: K20shores <[email protected]>

* Use consistent dimension labels with underscores in Run() docstring

Co-authored-by: K20shores <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: K20shores <[email protected]>

* responding to pr comments

* adding ffmpeg

---------

Co-authored-by: Kyle Shores <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: K20shores <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants