Conversation
|
📄 Documentation for this branch is available at: https://ncar.github.io/musica/branch/701-ts1-integration-test-and-example/ |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #753 +/- ##
==========================================
- Coverage 74.63% 73.81% -0.82%
==========================================
Files 109 110 +1
Lines 8106 8200 +94
==========================================
+ Hits 6050 6053 +3
- Misses 2056 2147 +91
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Updates TS1 support by correcting converted reaction rate constants and adding a TS1 box-model example and wheel-test coverage, including a new CLI option to control V0→V1 reaction unit conversion.
Changes:
- Add an option to skip reaction-unit conversion during V0→V1 conversion and propagate it through C++/Python/CLI layers.
- Add a TS1 box-model example and register it in the examples catalog; expand wheel tests to run examples and TS1 conversion.
- Update the bundled TS1 V1 configuration to reflect corrected rate constants and related schema/field adjustments.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/unit/micm/parser.cpp | Updates/disablements in MICM parser + conversion unit tests. |
| src/micm/convert_v0_to_v1.cpp | Adds unit-conversion toggle, name prefix stripping, and other V0→V1 conversion behavior changes. |
| python/musica/mechanism_configuration/utils.py | Adjusts serialization cleanup logic for empty values. |
| python/musica/main.py | Adds --no-convert-units CLI option and threads it into conversion. |
| python/musica/examples/ts1_box_model.py | Adds TS1 box model runnable example. |
| python/musica/examples/examples.py | Registers TS1 box model example for musica-cli -e. |
| python/bindings/mechanism_configuration/mechanism_configuration.cpp | Updates pybind API to pass unit-conversion toggle into C++. |
| pyproject.toml | Expands cibuildwheel test extras and test-command coverage for examples/conversion. |
| include/musica/micm/parse.hpp | Updates C++ ConvertV0MechanismToV1 signatures with a defaulted unit-conversion toggle. |
| configs/v1/ts1/ts1.json | Updates TS1 V1 mechanism data (rate constants, fields/structure). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
…n.cpp Co-authored-by: Copilot <[email protected]>
Closes #701