Conversation
K20shores
commented
Jan 14, 2026
K20shores
commented
- includes configurations in javascript package
- updates the example webpage to support two examples: a lorenz attractor as well as a simpble A->B->C system
|
📄 Documentation for this branch is available at: https://ncar.github.io/musica/branch/update_exmaples_packaging/ |
There was a problem hiding this comment.
Pull request overview
This PR updates the JavaScript package to include configuration files and enhances the example webpage with interactive demonstrations. The version is bumped from 0.14.3 to 0.14.4.
Changes:
- Includes
configsdirectory in the JavaScript package distribution (excludingconfigs/tuvx) - Updates example webpage with two interactive examples: Lorenz Polynomial CRN and A→B→C chain reaction
- Updates README with examples showing both in-code mechanism definition and configuration file usage
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 25 comments.
| File | Description |
|---|---|
| package.json | Version bump to 0.14.4 and adds configs to package files |
| CMakeLists.txt | Version bump to 0.14.4 for consistency |
| javascript/README.md | Adds examples section showing configuration file usage |
| javascript/wasm/example.html | Complete redesign with interactive UI for multiple examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <title>MUSICA WASM Example</title> | ||
| <style> | ||
| :root { | ||
| --max-width: 1100px |
There was a problem hiding this comment.
Missing semicolon at the end of the CSS property declaration. While not strictly required for the last property in a block, it's a best practice to include semicolons consistently for all CSS declarations.
| display: flex; | ||
| flex-direction: column; | ||
| gap: 6px; | ||
| margin-bottom: 18px |
There was a problem hiding this comment.
Missing semicolon at the end of the CSS property declaration. While not strictly required for the last property in a block, it's a best practice to include semicolons consistently for all CSS declarations.
| .slider-row .val { | ||
| width: 56px; | ||
| text-align: right; | ||
| font-weight: 600 |
There was a problem hiding this comment.
Missing semicolon at the end of the CSS property declaration. While not strictly required for the last property in a block, it's a best practice to include semicolons consistently for all CSS declarations.
|
|
||
| table.results { | ||
| width: 100%; | ||
| border-collapse: collapse |
There was a problem hiding this comment.
Missing semicolon at the end of the CSS property declaration. While not strictly required for the last property in a block, it's a best practice to include semicolons consistently for all CSS declarations.
| border-collapse: collapse | |
| border-collapse: collapse; |
| table.results td { | ||
| border: 1px solid #e6e6e6; | ||
| padding: 6px; | ||
| text-align: left |
There was a problem hiding this comment.
Missing semicolon at the end of the CSS property declaration. While not strictly required for the last property in a block, it's a best practice to include semicolons consistently for all CSS declarations.
|
|
||
| @media (max-width:900px) { | ||
| .layout { | ||
| flex-direction: column |
There was a problem hiding this comment.
Missing semicolon at the end of the CSS property declaration. While not strictly required for the last property in a block, it's a best practice to include semicolons consistently for all CSS declarations.
| } | ||
|
|
||
| .left { | ||
| flex-basis: auto |
There was a problem hiding this comment.
Missing semicolon at the end of the CSS property declaration. While not strictly required for the last property in a block, it's a best practice to include semicolons consistently for all CSS declarations.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #733 +/- ##
=======================================
Coverage 75.80% 75.80%
=======================================
Files 108 108
Lines 7974 7974
=======================================
Hits 6045 6045
Misses 1929 1929
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
