Conversation
|
📄 Documentation for this branch is available at: https://ncar.github.io/musica/branch/javascript_docker/ |
There was a problem hiding this comment.
Pull request overview
This PR adds Docker support for building and testing the JavaScript/WebAssembly interface of MUSICA. The changes enable continuous integration testing of the JavaScript components using an Emscripten-based Docker container.
Key Changes:
- Added Dockerfile.javascript with Emscripten SDK base image and CMake 3.24 installation
- Updated CMake minimum version requirement from 3.21 to 3.24
- Extended GitHub Actions workflow to build and test the JavaScript Docker image
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| docker/Dockerfile.javascript | New Dockerfile using Emscripten SDK for JavaScript/WASM builds with CMake 3.24 installation |
| CMakeLists.txt | Bumped minimum CMake version from 3.21 to 3.24 |
| .github/workflows/docker.yml | Added Dockerfile.javascript to build matrix and included separate test step for JavaScript tests |
| .dockerignore | Added JavaScript-related files (javascript/, package.json, package-lock.json) to include list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #721 +/- ##
=======================================
Coverage 76.63% 76.63%
=======================================
Files 108 108
Lines 7849 7849
=======================================
Hits 6015 6015
Misses 1834 1834
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.