Sync project version across C++, Python, and Javascript builds#643
Merged
Sync project version across C++, Python, and Javascript builds#643
Conversation
Contributor
|
📄 Documentation for this branch is available at: https://ncar.github.io/musica/branch/TAMU_Capstone_FA25_Sync_Version/ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #643 +/- ##
==========================================
+ Coverage 78.11% 78.24% +0.12%
==========================================
Files 54 54
Lines 6827 6857 +30
==========================================
+ Hits 5333 5365 +32
+ Misses 1494 1492 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
K20shores
requested changes
Oct 10, 2025
Collaborator
K20shores
left a comment
K20shores
left a comment
There was a problem hiding this comment.
After reviewing this, I've changed my mind. Below summarizes what I want
- Don't write out a verison file
- One javascript file which reads the version from CMakeLists.txt and writes it into package.json
…o one file can read version from CMakeLists and sync to package.json and package-lock.json extract_version match CMakeLists
K20shores
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #621