Conversation
|
📄 Documentation for this branch is available at: https://ncar.github.io/musica/branch/612-organize-musica-directory/ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #632 +/- ##
=======================================
Coverage 78.24% 78.24%
=======================================
Files 54 54
Lines 6858 6858
=======================================
Hits 5366 5366
Misses 1492 1492 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR restructures the MUSICA library by organizing Python modules into subdirectories for each project (TUV-x, CARMA, mechanism configuration) within the /musica directory. This reorganization improves code organization and modularity while maintaining backward compatibility through proper imports.
Key changes include:
- Moving modules into project-specific subdirectories with proper
__init__.pyfiles - Updating import statements throughout the codebase to reflect the new structure
- Reorganizing C++ bindings directory structure
- Removing unused imports to clean up the codebase
Reviewed Changes
Copilot reviewed 36 out of 38 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| musica/init.py | Updated to import submodules instead of individual classes |
| musica/tuvx/init.py | New module init file for TUV-x components |
| musica/carma/init.py | New module init file for CARMA components |
| tutorials/7. carma.ipynb | Updated CARMA class references to use new module structure |
| Various test files | Updated import statements for moved TUV-x and CARMA classes |
| C++ binding files | Updated include paths and reorganized directory structure |
| musica/backend.py | Added error handling for backend import failures |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
K20shores
left a comment
K20shores
left a comment
There was a problem hiding this comment.
Would you mind splitting up types.py as well with this?
I was thinking that it might make more sense for it to be named micm instead of type, since including both the solver and state under type is a bit confusing. What do you think? |
Yes, or maybe put it into a folder called micm and split it into micm, state, conditions? Either way is fine with me |
Okay, I created an issue for this. I'll create an separate PR for this. |
This PR:
/musicadirectory for python modules by creating a subdirectory for each project (tuvx, carma, mechanism configuration)musica/folder #612