Mininal javascript build and version API functionality#618
Merged
Conversation
Contributor
|
📄 Documentation for this branch is available at: https://ncar.github.io/musica/branch/TAMU_Capstone_FA25/ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #618 +/- ##
=======================================
Coverage 78.11% 78.11%
=======================================
Files 54 54
Lines 6827 6827
=======================================
Hits 5333 5333
Misses 1494 1494 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
K20shores
requested changes
Sep 23, 2025
Collaborator
K20shores
left a comment
K20shores
left a comment
There was a problem hiding this comment.
It's close! There's some extraneous things that need to be removed though.
Also, please follow the patterns in cmake/summary.cmake to add options which can then be used in cmake/musica.settings.in
K20shores
requested changes
Sep 23, 2025
K20shores
requested changes
Sep 23, 2025
K20shores
reviewed
Sep 24, 2025
K20shores
requested changes
Sep 24, 2025
boulderdaze
requested changes
Sep 24, 2025
Collaborator
boulderdaze
left a comment
boulderdaze
left a comment
There was a problem hiding this comment.
Looks good! I just added a couple of comments and suggestions.
Co-authored-by: Jiwon Gim <[email protected]>
Co-authored-by: Jiwon Gim <[email protected]>
K20shores
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build Configuration: Updated CMakesLists.txt files
Core Infrastructure: Include essential binding files and headers needed for successful build.
closes #619