Skip to content

Use the latest tag of MICM#592

Merged
boulderdaze merged 4 commits intomainfrom
380-update-micm-tag
Aug 27, 2025
Merged

Use the latest tag of MICM#592
boulderdaze merged 4 commits intomainfrom
380-update-micm-tag

Conversation

@boulderdaze
Copy link
Copy Markdown
Collaborator

@boulderdaze boulderdaze commented Aug 26, 2025 •
edited
Loading

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 26, 2025

📄 Documentation for this branch is available at: https://ncar.github.io/musica/branch/380-update-micm-tag/

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 26, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 76.92308% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.14%. Comparing base (fa04738) to head (c2c5437).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/micm/v0_parse.cpp 53.84% 24 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #592      +/-   ##
==========================================
- Coverage   81.19%   81.14%   -0.05%     
==========================================
  Files          54       54              
  Lines        5960     6015      +55     
==========================================
+ Hits         4839     4881      +42     
- Misses       1121     1134      +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@boulderdaze boulderdaze changed the title Update the micm tag for MUSICA Use the latest tag of MICM and Mech Config Aug 26, 2025
@boulderdaze boulderdaze self-assigned this Aug 26, 2025
@boulderdaze boulderdaze requested a review from Copilot August 26, 2025 23:47
Copilot AI reviewed Aug 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the MICM and Mechanism Configuration dependencies to their latest versions and refactors the code to use the new builder pattern for creating chemical reactions.

  • Updates MICM dependency from v3.9.0 to commit d1c22955dc6af62cb4b2deb09d10bf19324e2340
  • Updates Mechanism Configuration dependency to commit 6d51b50c4b2b902541363506a7cf815a81c3fa57
  • Replaces direct Process construction with ChemicalReactionBuilder pattern throughout the codebase

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
cmake/dependencies.cmake Updates git tags for MICM and Mechanism Configuration dependencies
src/micm/v1_parse.cpp Refactors to use new builder pattern and updated API with micm::Yield type
src/micm/v0_parse.cpp Similar refactoring for v0 parser with builder pattern adoption
src/micm/convert_v0_to_v1.cpp Updates phase species handling to use PhaseSpecies type instead of strings

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@boulderdaze
Copy link
Copy Markdown
Collaborator Author

boulderdaze commented Aug 27, 2025

This PR is possibly blocked by the pending implementation of micm::PhaseSpecies.
Hi @mattldawson, could you share your plans for incorporating PhaseSpecies into MICM? Will it be added to the Phase class separately from Species or integrated in a different way?

The current micm::Phase class

  class Phase
  {
   public:
    std::string name_;
    /// @brief The list of species
    std::vector<Species> species_;
   }

@boulderdaze boulderdaze changed the title Use the latest tag of MICM and Mech Config Use the latest tag of MICM Aug 27, 2025
@boulderdaze boulderdaze marked this pull request as ready for review August 27, 2025 22:16
@boulderdaze
Copy link
Copy Markdown
Collaborator Author

boulderdaze commented Aug 27, 2025

This PR is possibly blocked by the pending implementation of micm::PhaseSpecies. Hi @mattldawson, could you share your plans for incorporating PhaseSpecies into MICM? Will it be added to the Phase class separately from Species or integrated in a different way?

The current micm::Phase class

  class Phase
  {
   public:
    std::string name_;
    /// @brief The list of species
    std::vector<Species> species_;
   }

Never mind! This PR only updates the MICM tag, as you're still working on mech config

@boulderdaze boulderdaze merged commit 50a1d4d into main Aug 27, 2025
68 checks passed
@boulderdaze boulderdaze deleted the 380-update-micm-tag branch August 27, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mattldawson mattldawson mattldawson approved these changes

@K20shores K20shores Awaiting requested review from K20shores

Assignees

@boulderdaze boulderdaze

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update all relevant files to reflect recent changes in Henry's Law configuration

4 participants

@boulderdaze @codecov-commenter @mattldawson