Building windows python wheels with fortran support by K20shores · Pull Request #585 · NCAR/musica

K20shores · 2025-08-15T21:08:16Z

Closes #590

The python tests actions now builds wheels for all operating system, and then uses these wheels to run the tests.
- This is a much better because it more closely follow what a user might get from pypi
Added msys2 to provide the mingw build tools for windows which includes gfortran
- using msys2 in ci
- arm support
  - Unused but leaving the composite action for use later

Attempts

Attempted support for windows arm
- LLVM's flang on windows arm for TUVx and CARMA
- Abandoned since there were symbol visibility issues
Attempted and then abandoned rtools to provide mingw on windows which provides gfortran
- Failed because we need to install other packages, and pacman intermittently failed with no easy resolution in sight

Other information
At first I tried to use rtools, like in scipy, so I heavily relied on what scipy does to support fortran on windows.

this workflow sets up Flang and pkg-config on arm windows. I made a similar one for amd based windows
Their testing action
Their windows action which helped me figure out how to configure windows to include a build that needs fortran. This also showed me that we should be building wheels, installing those wheels, and testing our files that way
Their repair bash script for wheel files

github-actions · 2025-08-15T21:08:30Z

📄 Documentation for this branch is available at: https://ncar.github.io/musica/branch/windows_build/

codecov-commenter · 2025-08-15T21:20:22Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.24%. Comparing base (659886a) to head (0763aef).
⚠️ Report is 93 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #585   +/-   ##
=======================================
  Coverage   78.24%   78.24%           
=======================================
  Files          54       54           
  Lines        6857     6857           
=======================================
  Hits         5365     5365           
  Misses       1492     1492

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull Request Overview

This PR enables building Windows Python wheels with Fortran support by configuring MSYS2 with MinGW64 toolchain. The changes allow the CI/CD pipeline to build, repair, and test wheels across all supported platforms (Linux, macOS, Windows) more consistently with what users will receive from PyPI.

Key changes:

Added MSYS2/MinGW64 setup for Windows CI to provide gfortran compiler
Implemented wheel building and testing workflow that mirrors user installation experience
Removed platform-specific restrictions that disabled TUVX and CARMA on Windows

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
python/musica/tools/repair_wheel_windows.sh	New script to repair Windows wheels using delvewheel
python/musica/tools/prepare_build_environment_windows.bat	Contains unresolved merge conflict markers
python/musica/test/integration/test_sulfate_box_model.py	Removed emoji from test output message
pyproject.toml	Enabled Windows builds, added wheel repair configuration, updated dependencies formatting
include/musica/carma/error.hpp	Removed duplicate `#pragma once` directive
CMakeLists.txt	Disabled CMake module scanning on macOS
.github/workflows/windows.yml	Migrated MinGW setup to composite action
.github/workflows/python-wheels.yml	Updated to build Windows wheels using MSYS2 environment
.github/workflows/python-tests.yml	Refactored to build and test wheels instead of direct installation
.github/windows_arm64_steps/action.yml	New composite action for ARM64 Windows setup (currently unused)
.github/windows_amd64_steps/action.yml	New composite action for AMD64 Windows setup with MSYS2

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

.github/windows_arm64_steps/action.yml

.github/workflows/python-wheels.yml

Co-authored-by: Copilot <[email protected]>

python/musica/tools/prepare_build_environment_windows.bat

…indows_build

K20shores changed the title ~~trying to get fortraon to compile on windows~~ Building windows python wheels with fortran support Aug 15, 2025

K20shores force-pushed the windows_build branch 2 times, most recently from 510df30 to 80fd4f0 Compare October 22, 2025 14:47

K20shores added 5 commits October 22, 2025 10:02

Add windows arm, try msys2, disable other tests

3b2f7b1

Trying rtools, only debugging windows builds

81ef953

Attempting msys2 for windows arm and amd

2576493

Re-enabling other OSes, using repair script for windows

fb376af

Disabling module scans on mac

4cba2fc

K20shores force-pushed the windows_build branch from 80fd4f0 to 4cba2fc Compare October 22, 2025 15:02

K20shores added 2 commits October 22, 2025 10:16

enabling other actions

2f9026e

removing ifdefs

b04913d

K20shores marked this pull request as ready for review October 22, 2025 15:33

K20shores requested a review from Copilot October 22, 2025 15:34

Copilot AI reviewed Oct 22, 2025

View reviewed changes

.github/windows_arm64_steps/action.yml Outdated Show resolved Hide resolved

.github/workflows/python-wheels.yml Outdated Show resolved Hide resolved

K20shores and others added 2 commits October 22, 2025 10:36

Update .github/windows_arm64_steps/action.yml

71a3d12

Co-authored-by: Copilot <[email protected]>

Update .github/workflows/python-wheels.yml

4d410a5

Co-authored-by: Copilot <[email protected]>

K20shores requested a review from boulderdaze October 22, 2025 15:58

boulderdaze reviewed Oct 22, 2025

View reviewed changes

python/musica/tools/prepare_build_environment_windows.bat Outdated Show resolved Hide resolved

K20shores added 2 commits October 22, 2025 11:31

removing file

3186069

Merge branch 'windows_build' of https://github.com/NCAR/musica into w…

0763aef

…indows_build

boulderdaze approved these changes Oct 22, 2025

View reviewed changes

K20shores merged commit 2f59d9b into main Oct 22, 2025
107 of 109 checks passed

K20shores deleted the windows_build branch October 22, 2025 21:27

K20shores mentioned this pull request Oct 28, 2025

Test the built python wheel files #627

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Building windows python wheels with fortran support#585

Building windows python wheels with fortran support#585
K20shores merged 11 commits intomainfrom
windows_build

K20shores commented Aug 15, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Aug 15, 2025

Uh oh!

codecov-commenter commented Aug 15, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

K20shores commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 15, 2025

Uh oh!

codecov-commenter commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

K20shores commented Aug 15, 2025 •

edited

Loading

codecov-commenter commented Aug 15, 2025 •

edited

Loading