Conversation
|
📄 Documentation for this branch is available at: https://ncar.github.io/musica/branch/develop-set-functions/ |
There was a problem hiding this comment.
Pull Request Overview
This PR adds the remaining CARMA state setting functions to enable comprehensive state configuration for CARMA simulations. The changes extend the existing API to support setting temperature and air density profiles, while also enhancing the SetBin function to accept an optional surface mass parameter.
- Adds
SetTemperatureandSetAirDensityfunctions across all language bindings (C++, Fortran, Python) - Enhances
SetBinfunction with optional surface mass parameter - Updates test files to demonstrate and validate the new functionality
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/carma/interface.F90 | Adds Fortran interface functions for temperature and air density setting, updates SetBin signature |
| src/carma/carma_state.cpp | Implements C++ SetTemperature and SetAirDensity methods, adds surface_mass parameter to SetBin |
| include/musica/carma/carma_state.hpp | Declares new C++ method signatures with proper documentation |
| include/musica/carma/carma_c_interface.hpp | Adds C interface declarations for new functions |
| musica/carma.py | Implements Python wrapper methods for temperature and air density setting |
| musica/carma.cpp | Adds Python bindings for the new C++ functions |
| src/test/unit/carma/carma_c_api.cpp | Updates C++ tests to use new function signatures and test new capabilities |
| musica/test/test_carma.py | Updates Python tests to demonstrate new state setting functions |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #538 +/- ##
==========================================
+ Coverage 83.68% 84.27% +0.59%
==========================================
Files 51 51
Lines 5412 5464 +52
==========================================
+ Hits 4529 4605 +76
+ Misses 883 859 -24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adds the remaining CARMA state set functions.
Also updates the python tests to more closely mimic the C++ tests, and fixes an incorrect call to
SetBinin the python wrapper