Merged
Conversation
Contributor
|
📄 Documentation for this branch is available at: https://ncar.github.io/musica/branch/develop-486-carma-step/ |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR exposes the CARMASTATE_Step() function to the C and Python APIs, allowing users to perform single simulation steps with configurable parameters instead of running the full simulation.
- Adds new data structures for surface properties and step configuration
- Implements the step function across the C interface, C++ wrapper, and Python binding
- Updates test cases to use the new step functionality
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/carma/carma_parameters.F90 | Defines Fortran types for surface properties and step configuration |
| src/carma/interface.F90 | Implements the Fortran interface for the step function |
| include/musica/carma/carma_c_interface.hpp | Declares C interface structures and function |
| include/musica/carma/carma_state.hpp | Adds C++ structures and step method declaration |
| src/carma/carma_state.cpp | Implements the C++ step method with parameter conversion |
| musica/carma.cpp | Implements Python binding with parameter parsing |
| musica/carma.py | Adds Python classes and step method |
| musica/test/test_carma.py | Updates test to use step function instead of run |
| src/test/unit/carma/carma_c_api.cpp | Adds C++ unit test for step functionality |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #533 +/- ##
==========================================
- Coverage 83.73% 83.68% -0.06%
==========================================
Files 51 51
Lines 5355 5411 +56
==========================================
+ Hits 4484 4528 +44
- Misses 871 883 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
K20shores
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes the
CARMASTATE_Step()function to the C and Python APIs.closes #486