Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds CARMA initialization options by wrapping the CARMA_Initialize() function for both C and Python APIs. It introduces comprehensive configuration for CARMA's initialization parameters, including process flags, numerical parameters, and accommodation coefficients.
Key changes include:
- Addition of
CARMAInitializationConfigstructure with 19 configurable parameters - Integration of initialization configuration into the CARMA parameter structure
- Replacement of hardcoded initialization with dynamic configuration based on user settings
- Addition of valgrind suppressions for memory check issues in CARMA functions
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| valgrind.supp | Adds memory check suppressions for CARMA functions |
| src/test/unit/carma/carma_c_api.cpp | Updates test to use new initialization config and removes unused gas configurations |
| src/carma/interface.F90 | Replaces hardcoded CARMA_Initialize call with dynamic parameter-based configuration |
| src/carma/carma_parameters.F90 | Defines the Fortran initialization configuration structure |
| src/carma/carma.cpp | Implements C++ to C structure conversion for initialization config |
| musica/carma.py | Adds Python CARMAInitializationConfig class with comprehensive parameter support |
| musica/carma.cpp | Implements Python dictionary to C++ structure conversion for initialization |
| include/musica/carma/carma_c_interface.hpp | Defines C-compatible initialization configuration structure |
| include/musica/carma/carma.hpp | Defines C++ initialization configuration structure |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #521 +/- ##
=======================================
Coverage 83.74% 83.75%
=======================================
Files 51 51
Lines 5181 5196 +15
=======================================
+ Hits 4339 4352 +13
- Misses 842 844 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
K20shores
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps the
CARMA_Initialize()function for the C and Python APIs. Also adds a few valgrind suppressions that should be removed after theCARMASTATE_*functions are finished.closes #483