Merged
Conversation
* remove max bins/groups * add missing CARMA group options * address copilot comments
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR exposes all options for creating CARMA Element objects through the MUSICA C and Python APIs, removes arguments that can be inferred, and standardizes on SI units. The changes include adding new enumeration classes for particle algorithms, removing ID fields that can be inferred, converting units from CGS to SI, and adding support for complex refractive indices.
Key changes:
- Adds comprehensive enumeration classes for particle swelling, fall velocity, Mie calculation, and optics algorithms
- Removes manually assigned ID fields from group and element configurations
- Converts density and radius units from CGS (g/cm³, cm) to SI (kg/m³, m) throughout the codebase
- Adds support for complex refractive index arrays in element configurations
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/carma/interface.F90 | Updates Fortran interface to handle new parameters and unit conversions |
| src/carma/carma_parameters.F90 | Adds complex number type and removes ID fields from configuration structs |
| src/carma/carma.cpp | Updates C++ parameter conversion with new fields and unit handling |
| musica/carma.py | Adds new enumeration classes and updates configuration classes with SI units |
| musica/carma.cpp | Updates Python binding to handle new parameter structure |
| include/musica/carma/carma_c_interface.hpp | Updates C interface structs with new fields and documentation |
| include/musica/carma/carma.hpp | Adds new enumerations and updates configuration structs |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
==========================================
- Coverage 84.85% 84.23% -0.63%
==========================================
Files 49 49
Lines 4735 4777 +42
==========================================
+ Hits 4018 4024 +6
- Misses 717 753 +36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
K20shores
approved these changes
Jul 28, 2025
mattldawson
added a commit
that referenced
this pull request
Jul 28, 2025
* add CARMA element options * CARMA group options (#500) * remove max bins/groups * add missing CARMA group options * address copilot comments * address copilot comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes all options for creating CARMA Element objects through the MUSICA C and Python APIs. Also removes arguments that can be inferred and uses SI units.
closes #471