Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CARMA wrapper to include all options from the CARMA_Create() function in the Python API and moves initialization steps from the Run() function to the constructor. The changes refactor the CARMA interface to separate object creation from simulation execution.
Key changes:
- CARMA instance initialization moved to constructor with parameters
- Added wavelength bin configuration support with emission flags
- Split CARMA lifecycle into create, run, and destroy phases
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| valgrind.supp | Removes CARMA-specific memory leak suppression rules |
| src/test/unit/carma/carma_c_api.cpp | Updates tests to use constructor-based initialization |
| src/carma/interface.F90 | Splits run function into create/run/destroy phases and adds wavelength support |
| src/carma/carma_parameters.F90 | Adds wavelength bin structure and removes nwave parameter |
| src/carma/carma.cpp | Refactors to use constructor initialization and pointer-based parameter management |
| musica/test/test_carma.py | Updates Python tests to use new constructor pattern |
| musica/carma.py | Adds wavelength bin class and updates parameter structure |
| musica/carma.cpp | Updates Python binding to handle wavelength bins and new API |
| include/musica/carma/carma_c_interface.hpp | Adds wavelength bin structure and updates interface signatures |
| include/musica/carma/carma.hpp | Updates class interface to use constructor initialization |
Comments suppressed due to low confidence (1)
src/test/unit/carma/carma_c_api.cpp:56
- This test is checking for a field
params.nwavethat no longer exists according to the changes in the parameters structure. This line should be removed or updated to check the new wavelength_bins field.
EXPECT_EQ(params.dtime, 1800.0);
Co-authored-by: GitHub Actions <[email protected]>
Co-authored-by: GitHub Actions <[email protected]>
Co-authored-by: GitHub Actions <[email protected]>
Co-authored-by: GitHub Actions <[email protected]>
Co-authored-by: GitHub Actions <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #491 +/- ##
==========================================
+ Coverage 84.85% 85.04% +0.18%
==========================================
Files 49 49
Lines 4815 4873 +58
==========================================
+ Hits 4086 4144 +58
Misses 729 729 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
K20shores
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the CARMA wrapper to include all options from the
CARMA_Create()function in the Python API. It also moves initialization steps to the constructor instead of theRun()functioncloses #469