Add GPU Solver Tutorial + Minor Changes to Other Tutorials#429
Add GPU Solver Tutorial + Minor Changes to Other Tutorials#429aidan-winney merged 4 commits intomainfrom
Conversation
|
📄 Documentation for this branch is available at: https://ncar.github.io/musica/branch/musica_tutorial_2/ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #429 +/- ##
=======================================
Coverage 83.63% 83.63%
=======================================
Files 48 48
Lines 4093 4093
=======================================
Hits 3423 3423
Misses 670 670 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tutorial/6. gpu_solver.ipynb
Outdated
| " reactions=[r1, r2]\n", | ||
| " )\n", | ||
| "\n", | ||
| " solver = musica.MICM(mechanism = mechanism, solver_type = musica.SolverType.rosenbrock_standard_order)\n", |
There was a problem hiding this comment.
| " solver = musica.MICM(mechanism = mechanism, solver_type = musica.SolverType.rosenbrock_standard_order)\n", | |
| " solver = musica.MICM(mechanism = mechanism, solver_type = musica.SolverType.cuda_rosenbrock)\n", |
It should be this
There was a problem hiding this comment.
Thanks @K20shores for catching this. @aidan-winney can you confirm that switching to cuda_rosenbrock still works in your case?
There was a problem hiding this comment.
Yes, it still works, thanks for catching that
sjsprecious
left a comment
sjsprecious
left a comment
There was a problem hiding this comment.
Thanks @aidan-winney for working on this PR. It looks good and I just have a few minor comments.
tutorial/6. gpu_solver.ipynb
Outdated
| " reactions=[r1, r2]\n", | ||
| " )\n", | ||
| "\n", | ||
| " solver = musica.MICM(mechanism = mechanism, solver_type = musica.SolverType.rosenbrock_standard_order)\n", |
There was a problem hiding this comment.
Thanks @K20shores for catching this. @aidan-winney can you confirm that switching to cuda_rosenbrock still works in your case?
4 participants
Closes #426
This pull request adds the GPU solver tutorial that delineates how to enable a GPU on a Linux system. It also fixes some issues brought up with the other tutorials.