Fix case sensitive string comparison in pkgconfig generation#372
Merged
mattldawson merged 1 commit intomainfrom Jun 13, 2025
Merged
Fix case sensitive string comparison in pkgconfig generation#372mattldawson merged 1 commit intomainfrom
mattldawson merged 1 commit intomainfrom
Conversation
Contributor
|
📄 Documentation for this branch is available at: https://ncar.github.io/musica/branch/develop-bug-fix-yaml-cpp-debug/ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #372 +/- ##
=======================================
Coverage 87.09% 87.09%
=======================================
Files 43 43
Lines 3860 3860
=======================================
Hits 3362 3362
Misses 498 498 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
montythind
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A case-sensitive string comparison was being used to check the CMake build type when creating the pkf-config file. This modifies the logic to use case-insensitive comparisons.