Set the temporary value for diffusion coefficient#846
Merged
boulderdaze merged 2 commits intomainfrom Sep 22, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #846 +/- ##
==========================================
- Coverage 94.65% 94.53% -0.12%
==========================================
Files 71 71
Lines 3946 3951 +5
==========================================
Hits 3735 3735
- Misses 211 216 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
K20shores
approved these changes
Sep 22, 2025
boulderdaze
deleted the
remove_diffusion_coefficient_from_species_requirement
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds temporary workaround to read diffusion coefficients.
Some tests use manually created species with specified diffusion coefficients, which led to test failures. This will be addressed in the following issue.